Issue 255094: [Mac] Properly call setIsActive() when becoming and resigning key window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255094: [Mac] Properly call setIsActive() when becoming and resigning key window. (Closed)

Created:
11 years, 2 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
Amanda Walker

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

[Mac] Properly call setIsActive() when becoming and resigning key window. BUG=http://crbug.com/21738 TEST=TestShell windows should properly become inactive when not key windows. Scrollbars and highlighted text should be grey, not blue. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29701

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -12 lines)			Patch
M	webkit/tools/test_shell/mac/test_shell_webview.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/mac/test_shell_webview.mm	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/mac/webview_host.mm	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_mac.mm	View	1	5 chunks	+36 lines, -12 lines	0 comments	Download
M	webkit/tools/test_shell/webview_host.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

This probably isn't strictly needed, but it felt wrong to add layout-test-mode functionality without also ...

11 years, 2 months ago (2009-10-20 22:28:27 UTC) #1

LGTM

Expand Messages | Collapse Messages