Issue 255078: gyp_chromium automatically includes features_override.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255078: gyp_chromium automatically includes features_override.gypi (Closed)

Created:
11 years, 2 months ago by yaar

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, tony

Visibility:
Public.

gyp_chromium automatically includes features_override.gypi Other projects that use gyp_chromium directly depend on that. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28035

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	build/gyp_chromium	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

yaar

Hi mark! This is the chromium side of: https://bugs.webkit.org/show_bug.cgi?id=29986 Thanks for reviewing this. -Yaar

11 years, 2 months ago (2009-10-05 17:52:33 UTC) #1

LGTM