Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: webkit/default_plugin/default_plugin_shared.h

Issue 255061: Re-land http://codereview.chromium.org/211031 with a bug opened... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/plugins/plugin_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/default_plugin/default_plugin_shared.h
===================================================================
--- webkit/default_plugin/default_plugin_shared.h (revision 28818)
+++ webkit/default_plugin/default_plugin_shared.h (working copy)
@@ -11,11 +11,11 @@
namespace default_plugin {
// We use the NPNGetValue host function to send notification message to host.
-// This corresponds to NPNVariable defined in npapi.h. However, we don't care
-// too much about value conflicts because on the host side, it will only respond
-// to such request coming from default plugin.
-const int kMissingPluginStatusStart = 3000;
+// This corresponds to NPNVariable defined in npapi.h, and should be chosen so
+// as to not overlap values if NPAPI is updated.
+const int kMissingPluginStatusStart = 5000;
+
enum MissingPluginStatus {
MISSING_PLUGIN_AVAILABLE,
MISSING_PLUGIN_USER_STARTED_DOWNLOAD
« no previous file with comments | « no previous file | webkit/glue/plugins/plugin_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698