Issue 255061: Re-land http://codereview.chromium.org/211031 with a bug opened...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255061: Re-land http://codereview.chromium.org/211031 with a bug opened... (Closed)

Created:
11 years, 2 months ago by Amanda Walker

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, John Grabowski, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Re-land http://codereview.chromium.org/211031 with a bug opened for the couple of layout tests that break (since they should not have been passing if the QuickTime plugin wasn't loading). BUG=12030 TEST=Quickdraw based plugins (such as the QuickTime plugin) should not crash when invoked, and may even display properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28837

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -58 lines)			Patch
M	webkit/default_plugin/default_plugin_shared.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/plugin_host.cc	View	1	3 chunks	+49 lines, -9 lines	0 comments	Download
M	webkit/glue/plugins/plugin_instance.h	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_instance.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_list_mac.mm	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View	1	11 chunks	+153 lines, -32 lines	0 comments	Download

Total messages: 2 (0 generated)

Amanda Walker

Passes all layout tests locally, will file a bug if something shows up on the ...

11 years, 2 months ago (2009-10-13 17:20:13 UTC) #1

LGTM!