chrome/browser/tab_contents/tab_contents_view_gtk.cc - Issue 255028: Pass unhandled keyup messages coming in from the renderer to the underlying v...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_contents_view_gtk.cc

Issue 255028: Pass unhandled keyup messages coming in from the renderer to the underlying v... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/tab_contents/tab_contents_view_gtk.cc

===================================================================

--- chrome/browser/tab_contents/tab_contents_view_gtk.cc (revision 27870)

+++ chrome/browser/tab_contents/tab_contents_view_gtk.cc (working copy)

@@ -571,7 +571,10 @@

// |event.os_event| values are dummy values (or NULL.)

// We should filter out these pseudo key events to prevent unexpected

// behaviors caused by them.

- if (event.type == WebKit::WebInputEvent::Char)

+ // We should also filter out the KeyUp event as it should not be processed

+ // as an accelerator.

+ if (event.type == WebKit::WebInputEvent::Char ||

+ event.type == WebKit::WebInputEvent::KeyUp)

return;

BrowserWindowGtk* browser_window =

« no previous file with comments | « chrome/browser/renderer_host/render_view_host.cc ('k') | no next file » | no next file with comments »