Issue 255015: The buildbots compile into src/build/{Debug,Release} but this script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255015: The buildbots compile into src/build/{Debug,Release} but this script (Closed)

Created:
11 years, 2 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

The buildbots compile into src/build/{Debug,Release} but this script assumes that the build output is in src/chrome/{Debug,Release}. Update the clobber script to look in both places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27580

Patch Set 1 #

Total comments: 1

Patch Set 2 : all dirs #

Total comments: 1

Patch Set 3 : rebase #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
	M	build/win/clobber_generated_headers.py	View	1 2	1 chunk	+20 lines, -16 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with this change http://codereview.chromium.org/255015/diff/1/2 File build/win/clobber_generated_headers.py (right): http://codereview.chromium.org/255015/diff/1/2#newcode47 Line 47: for out_dir in ('chrome', ...

11 years, 2 months ago (2009-09-30 00:11:36 UTC) #2

M-A Ruel

lgtm http://codereview.chromium.org/255015/diff/2002/3002 File build/win/clobber_generated_headers.py (right): http://codereview.chromium.org/255015/diff/2002/3002#newcode64 Line 64: fmt = 'Could not remove %s: %s. ...

11 years, 2 months ago (2009-09-30 00:31:00 UTC) #4

LGTM, thanks for fixing this

Expand Messages | Collapse Messages