Do not flatten the string, but just write it out....

Do not flatten the string, but just write it out.

In DOM bindings in many cases the string would be externalized immediately.  For other cases
I am going to add explicit flattening.  Overall, it looks like if user wants to flat string
before writing, it should be an explicit method invocation (going to add TryFlattenIfNotFlat
into public V8 API).


Committed: http://code.google.com/p/v8/source/detail?r=2999

[Erik Corry, 2009-09-29 18:31:13]

Apart from that one comment it LGTM, and I'm annoyed with myself for not
suggesting this in response to the first patch you sent out!

http://codereview.chromium.org/255004/diff/2001/3001
File src/api.cc (right):

http://codereview.chromium.org/255004/diff/2001/3001#newcode2454
Line 2454: if (end < length)
Seems like this version doesn't put a trailing null on if the length is -1,
whereas the old version did.

[antonm, 2009-09-29 20:53:10]

Thanks a lot for review, Erik!

I'd give others a change, and if nobody speaks up, submit it tomorrow when in
the office (rather late)

http://codereview.chromium.org/255004/diff/2001/3001
File src/api.cc (right):

http://codereview.chromium.org/255004/diff/2001/3001#newcode2454
Line 2454: if (end < length)
On 2009/09/29 18:31:13, Erik Corry wrote:
> Seems like this version doesn't put a trailing null on if the length is -1,
> whereas the old version did.

Stupid me, thanks.

[Christian Plesner Hansen, 2009-09-30 11:32:40]

Lgtm