Issue 2549001: Refine gbb_utility for better maintainance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2549001: Refine gbb_utility for better maintainance (Closed)

Created:
10 years, 6 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/chromiumos

Visibility:
Public.

Description

Refine gbb_utility for better maintainance * now -g (get mode) becomes default * properties are now managed in a more generalized way so adding new property would be more easy

Patch Set 1 #

Patch Set 2 : fix lint errors (extra space) #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -130 lines)			Patch
	M	src/platform/vboot_reference/utility/gbb_utility.cc	View	1	12 chunks	+210 lines, -108 lines	0 comments	Download
	M	src/platform/vboot_reference/utility/include/gbb_utility.h	View		3 chunks	+30 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks

Expand Messages | Collapse Messages