Issue 2545001: Fix gcl upload with moved files without modification on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2545001: Fix gcl upload with moved files without modification on Windows. (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
gene

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fix gcl upload with moved files without modification on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48793

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	scm.py	View		2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

The file needs to use '/' in the diff, that's what upload.py expects. http://codereview.chromium.org/2545001/diff/1/2 File ...

10 years, 6 months ago (2010-06-03 00:02:16 UTC) #1

gene

10 years, 6 months ago (2010-06-03 00:05:11 UTC) #2

lgtm

On 2010/06/03 00:02:16, Marc-Antoine Ruel wrote:
> The file needs to use '/' in the diff, that's what upload.py expects.
> 
> http://codereview.chromium.org/2545001/diff/1/2
> File scm.py (right):
> 
> http://codereview.chromium.org/2545001/diff/1/2#newcode48
> scm.py:48: filename = filename.replace(os.sep, '/')
> I don't think this one is necessary but while at it...

Expand Messages | Collapse Messages