Issue 2544003: Ensures that cold startup perf tests clear more DLLs. Helps bring results int...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2544003: Ensures that cold startup perf tests clear more DLLs. Helps bring results int... (Closed)

Created:
10 years, 6 months ago by slightlyoff

Modified:
10 years, 6 months ago

Reviewers:
amit, joshia

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Ensures that cold startup perf tests clear more DLLs. Helps bring results into line with worst-case expectations on Vista. BUG=None TeST=run GCF perftests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48799

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
	M	chrome_frame/test/perf/chrome_frame_perftest.cc	View	1 2	4 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 6 months ago (2010-06-03 00:56:26 UTC) #2

Good idea, LGTM

http://codereview.chromium.org/2544003/diff/4001/5001
File chrome_frame/test/perf/chrome_frame_perftest.cc (right):

http://codereview.chromium.org/2544003/diff/4001/5001#newcode328
chrome_frame/test/perf/chrome_frame_perftest.cc:328: LOG(ERROR) <<
GetLastError();
nit: It's better to record/trace error right after the API call. Doing it after
a few APIs might reset the error code.

Expand Messages | Collapse Messages