Issue 254007: Wires up views on linux dialogs to use gtk ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254007: Wires up views on linux dialogs to use gtk ones. (Closed)

Created:
11 years, 2 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Wires up views on linux dialogs to use gtk ones. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27484

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -37 lines)			Patch
M	chrome/browser/browser_theme_provider.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_theme_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/defaults.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	1	3 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/gtk_theme_provider.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/options/content_page_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/profile.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/dialog_stubs_gtk.cc	View		1 chunk	+28 lines, -21 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		3 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. What is the theme manager needed for? Also, is this a long term plan ...

11 years, 2 months ago (2009-09-28 23:18:30 UTC) #2

sky

11 years, 2 months ago (2009-09-28 23:28:20 UTC) #3

On 2009/09/28 23:18:30, tony wrote:
> LGTM.
> 
> What is the theme manager needed for?

Do you mean GtkThemeProvider? There are a couple of statics in there used in
places to get images.

> Also, is this a long term plan or just
> something temporary for the views linux build?

I don't have a good answer to that. It's most likely short term, but it could
end up dragging on.

> If you plan to use these long
> term, maybe we should move them?

I agree. If we're going to stay with this approach long term, then we should
shuffle the code around to make things clearer.

Expand Messages | Collapse Messages