Issue 254001: Don't assume that we build from the src/chrome folder....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254001: Don't assume that we build from the src/chrome folder.... (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't assume that we build from the src/chrome folder. This is still not perfect, but all least it should work for all the use cases we currently have. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27353

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/tools/build/win/create_installer_archive.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 2 months ago (2009-09-27 23:26:29 UTC) #2

lgtm with that fixed

http://codereview.chromium.org/254001/diff/1/2
File chrome/tools/build/win/create_installer_archive.py (right):

http://codereview.chromium.org/254001/diff/1/2#newcode58
Line 58: for line in open(os.path.join(output_dir, "..", "..", "chrome",
VERSION_FILE), 'r'):
80 cols

Expand Messages | Collapse Messages