Implemented ReadObjectsFromSlot() to populate pkcs11.slots on initialization.

Implemented ReadObjectsFromSlot() to populate pkcs11.slots on initialization.

[stevenjb, 2010-06-02 22:57:14]

Medium sized changeset to read and parse objects in the TPM so that we know
whether or not a particular certificate has been installed.

[Nathan Williams, 2010-06-02 23:37:13]

lgtm

[rginda, 2010-06-02 23:53:05]

http://codereview.chromium.org/2523001/diff/1/3
File pkcs11.cc (right):

http://codereview.chromium.org/2523001/diff/1/3#newcode1390
pkcs11.cc:1390: memcpy(&bytes.front(), idstrp, bytes.size());
Can you not construct the Blob with
  chromeos::Blog bytes(idstrp, idstrlen);

rather than resorting to memcpy?

[stevenjb, 2010-06-03 00:48:41]

One small change to avoid memcpy.

http://codereview.chromium.org/2523001/diff/1/3
File pkcs11.cc (right):

http://codereview.chromium.org/2523001/diff/1/3#newcode1390
pkcs11.cc:1390: memcpy(&bytes.front(), idstrp, bytes.size());
On 2010/06/02 23:53:06, rginda wrote:
> Can you not construct the Blob with
>   chromeos::Blog bytes(idstrp, idstrlen);
> 
> rather than resorting to memcpy?

Ah, almost. I forgot that a vector::iterator can be implicitly constructed from
a T*, so Blob(idstrp, idstrp+idstrlen) is valid. (range is [A,B) ).

Done.