Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2521001: AutoFill: Make PersonalDataManager RefCountedThreadSafe. (Closed)

Created:
10 years, 6 months ago by James Hawkins
Modified:
9 years, 7 months ago
CC:
chromium-reviews, idana, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org
Visibility:
Public.

Description

AutoFill: Make PersonalDataManager RefCountedThreadSafe. BUG=40617 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48858

Patch Set 1 #

Patch Set 2 : Fix compile. #

Patch Set 3 : Fix mac. #

Patch Set 4 : Fix lints. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -40 lines) Patch
M chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm View 3 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/autofill/autofill_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/autofill/autofill_manager_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager.h View 4 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/autofill/personal_data_manager_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profile.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/autofill_model_associator.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 11 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Hawkins
Switched branches, so new CL.
10 years, 6 months ago (2010-06-02 22:44:58 UTC) #1
James Hawkins
Stacktrace: [ RUN ] AutofillDataTypeControllerTest.StartPDMAndWDSReady [18763:18763:0602/153713:3785107988292:ERROR:base/process_util_posix.cc(105)] Received signal 11 StackTrace::StackTrace() [0x1895b09] base::(anonymous namespace)::StackDumpSignalHandler() [0x18c21d5] 0x7f9c163e3100 ...
10 years, 6 months ago (2010-06-02 22:51:06 UTC) #2
tim (not reviewing)
10 years, 6 months ago (2010-06-03 19:54:05 UTC) #3 
LGTM, sounds like the failures were fixed.

Powered by Google App Engine
This is Rietveld 408576698