Issue 2520002: Move MouseLeave ui test to interactive ui tests target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2520002: Move MouseLeave ui test to interactive ui tests target. (Closed)

Created:
10 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Move MouseLeave ui test to interactive ui tests target. BUG=45581, 26349, 45581 TEST=it runs, succeeds on bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48860

Patch Set 2 : enable #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
M	chrome/chrome_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/interactive_ui/interactive_ui_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/test/interactive_ui/mouseleave_interactive_uitest.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

LGTM. Thanks! http://codereview.chromium.org/2520002/diff/1/4 File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right): http://codereview.chromium.org/2520002/diff/1/4#newcode19 chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:19: #define TestOnMouseOut DISABLED_TestOnMouseOut If it actually passes, ...

10 years, 6 months ago (2010-06-03 03:41:55 UTC) #2

Evan Stade

10 years, 6 months ago (2010-06-03 20:42:52 UTC) #3

http://codereview.chromium.org/2520002/diff/1/4
File chrome/test/interactive_ui/mouseleave_interactive_uitest.cc (right):

http://codereview.chromium.org/2520002/diff/1/4#newcode19
chrome/test/interactive_ui/mouseleave_interactive_uitest.cc:19: #define
TestOnMouseOut DISABLED_TestOnMouseOut
On 2010/06/03 03:41:55, Dominic Mazzoni wrote:
> If it actually passes, do you want to remove DISABLED?

d'oh. yes

Expand Messages | Collapse Messages

Issue 2520002: Move MouseLeave ui test to interactive ui tests target. (Closed)

Description

Patch Set 1 #

Patch Set 2 : enable #

Messages