Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2512002: Ignore the top level build/ directory tree. (Closed)

Created:
10 years, 6 months ago by vb
Modified:
9 years, 6 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/kernel.git
Visibility:
Public.

Description

Ignore the top level build/ directory tree. This tree is generated by gentoo tools and should be ignored by git. Tested by observing that git does ignore the top level build/ tree, but does report build/ subtrees within the kernel tree.

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .gitignore View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vb
10 years, 6 months ago (2010-06-02 23:47:25 UTC) #1
Mandeep Singh Baines
Some minor nits. http://codereview.chromium.org/2512002/diff/1/2 File .gitignore (right): http://codereview.chromium.org/2512002/diff/1/2#newcode59 .gitignore:59: # gentoo build directory I don't ...
10 years, 6 months ago (2010-06-03 16:06:18 UTC) #2
vb
Please look again. http://codereview.chromium.org/2512002/diff/1/2 File .gitignore (right): http://codereview.chromium.org/2512002/diff/1/2#newcode59 .gitignore:59: # gentoo build directory On 2010/06/03 ...
10 years, 6 months ago (2010-06-03 16:28:54 UTC) #3
Mandeep Singh Baines
10 years, 6 months ago (2010-06-03 17:04:24 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698