Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: gclient_scm.py

Issue 251095: Revert "Modify the output of gclient update, gclient status to only print out" (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient.py ('k') | gclient_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index ce616816c1b822f1865006316055dba96601992a..553f8f9de7878773cfcbb32af25bed1621c62efb 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -250,7 +250,7 @@ class SVNWrapper(SCMWrapper):
command = ['checkout', url, checkout_path]
if revision:
command.extend(['--revision', str(revision)])
- RunSVNAndGetFileList(options, command, self._root_dir, file_list)
+ RunSVNAndGetFileList(command, self._root_dir, file_list)
return
# Get the existing scm url and the revision number of the current checkout.
@@ -261,12 +261,12 @@ class SVNWrapper(SCMWrapper):
"and try again." %
checkout_path)
- # Retrieve the current HEAD version because svn is slow at null updates.
- if not revision:
- from_info_live = CaptureSVNInfo(from_info['URL'], '.')
- revision = str(from_info_live['Revision'])
- rev_str = ' at %s' % revision
- forced_revision = True
+ if options.manually_grab_svn_rev:
+ # Retrieve the current HEAD version because svn is slow at null updates.
+ if not revision:
+ from_info_live = CaptureSVNInfo(from_info['URL'], '.')
+ revision = str(from_info_live['Revision'])
+ rev_str = ' at %s' % revision
if from_info['URL'] != components[0]:
to_info = CaptureSVNInfo(url, '.')
@@ -308,7 +308,7 @@ class SVNWrapper(SCMWrapper):
command = ['checkout', url, checkout_path]
if revision:
command.extend(['--revision', str(revision)])
- RunSVNAndGetFileList(options, command, self._root_dir, file_list)
+ RunSVNAndGetFileList(command, self._root_dir, file_list)
return
@@ -322,7 +322,7 @@ class SVNWrapper(SCMWrapper):
command = ["update", checkout_path]
if revision:
command.extend(['--revision', str(revision)])
- RunSVNAndGetFileList(options, command, self._root_dir, file_list)
+ RunSVNAndGetFileList(command, self._root_dir, file_list)
def revert(self, options, args, file_list):
"""Reverts local modifications. Subversion specific.
@@ -372,8 +372,7 @@ class SVNWrapper(SCMWrapper):
# svn revert is so broken we don't even use it. Using
# "svn up --revision BASE" achieve the same effect.
- RunSVNAndGetFileList(options, ['update', '--revision', 'BASE'], path,
- file_list)
+ RunSVNAndGetFileList(['update', '--revision', 'BASE'], path, file_list)
def runhooks(self, options, args, file_list):
self.status(options, args, file_list)
@@ -390,7 +389,7 @@ class SVNWrapper(SCMWrapper):
% (' '.join(command), path))
# There's no file list to retrieve.
else:
- RunSVNAndGetFileList(options, command, path, file_list)
+ RunSVNAndGetFileList(command, path, file_list)
def pack(self, options, args, file_list):
"""Generates a patch file which can be applied to the root of the
@@ -484,7 +483,7 @@ def CaptureSVN(args, in_directory=None, print_error=True):
stderr=stderr).communicate()[0]
-def RunSVNAndGetFileList(options, args, in_directory, file_list):
+def RunSVNAndGetFileList(args, in_directory, file_list):
"""Runs svn checkout, update, or status, output to stdout.
The first item in args must be either "checkout", "update", or "status".
@@ -494,7 +493,6 @@ def RunSVNAndGetFileList(options, args, in_directory, file_list):
sys.stdout as in RunSVN.
Args:
- options: command line options to gclient
args: A sequence of command line parameters to be passed to svn.
in_directory: The directory where svn is to be run.
@@ -534,7 +532,7 @@ def RunSVNAndGetFileList(options, args, in_directory, file_list):
RunSVNAndFilterOutput(args,
in_directory,
- options.verbose,
+ True,
True,
CaptureMatchingLines)
« no previous file with comments | « gclient.py ('k') | gclient_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698