Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/renderer/extensions/extension_api_client_unittest.cc

Issue 251093: Modify extension request IPC messages to pass a ListValue instead of a string. (Closed)
Patch Set: notreached messages Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/extensions/extension_process_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/extension_api_client_unittest.cc
diff --git a/chrome/renderer/extensions/extension_api_client_unittest.cc b/chrome/renderer/extensions/extension_api_client_unittest.cc
index 1a068895a0e39df7dc4e2c0f9a150bf90c325414..9e5fb530f2dc981739074289b605d2ddbb8104fa 100644
--- a/chrome/renderer/extensions/extension_api_client_unittest.cc
+++ b/chrome/renderer/extensions/extension_api_client_unittest.cc
@@ -3,6 +3,7 @@
// found in the LICENSE file.
#include "base/file_util.h"
+#include "base/json_reader.h"
#include "base/path_service.h"
#include "base/string_util.h"
#include "chrome/common/chrome_paths.h"
@@ -53,7 +54,14 @@ class ExtensionAPIClientTest : public RenderViewTest {
ViewHostMsg_ExtensionRequest::Param params;
ViewHostMsg_ExtensionRequest::Read(request_msg, &params);
ASSERT_EQ(function.c_str(), params.a) << js;
- ASSERT_EQ(arg1.c_str(), params.b) << js;
+
+ Value* args = NULL;
+ ASSERT_TRUE(params.b.IsType(Value::TYPE_LIST));
+ ASSERT_TRUE(static_cast<const ListValue*>(&params.b)->Get(0, &args));
+
+ JSONReader reader;
+ Value* arg1_value = reader.JsonToValue(arg1, false, false);
+ ASSERT_TRUE(args->Equals(arg1_value)) << js;
render_thread_.sink().ClearMessages();
}
};
« no previous file with comments | « chrome/common/render_messages_internal.h ('k') | chrome/renderer/extensions/extension_process_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698