Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.cc

Issue 251093: Modify extension request IPC messages to pass a ListValue instead of a string. (Closed)
Patch Set: notreached messages Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/tab_contents/tab_contents.h" 5 #include "chrome/browser/tab_contents/tab_contents.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "app/resource_bundle.h" 8 #include "app/resource_bundle.h"
9 #include "base/file_version_info.h" 9 #include "base/file_version_info.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
(...skipping 2190 matching lines...) Expand 10 before | Expand all | Expand 10 after
2201 } else { 2201 } else {
2202 OpenURL(url, referrer, disposition, PageTransition::LINK); 2202 OpenURL(url, referrer, disposition, PageTransition::LINK);
2203 } 2203 }
2204 } 2204 }
2205 2205
2206 void TabContents::DomOperationResponse(const std::string& json_string, 2206 void TabContents::DomOperationResponse(const std::string& json_string,
2207 int automation_id) { 2207 int automation_id) {
2208 } 2208 }
2209 2209
2210 void TabContents::ProcessDOMUIMessage(const std::string& message, 2210 void TabContents::ProcessDOMUIMessage(const std::string& message,
2211 const std::string& content, 2211 const Value* content,
2212 int request_id, 2212 int request_id,
2213 bool has_callback) { 2213 bool has_callback) {
2214 if (!render_manager_.dom_ui()) { 2214 if (!render_manager_.dom_ui()) {
2215 // This can happen if someone uses window.open() to open an extension URL 2215 // This can happen if someone uses window.open() to open an extension URL
2216 // from a non-extension context. 2216 // from a non-extension context.
2217 render_view_host()->BlockExtensionRequest(request_id); 2217 render_view_host()->BlockExtensionRequest(request_id);
2218 return; 2218 return;
2219 } 2219 }
2220 render_manager_.dom_ui()->ProcessDOMUIMessage(message, content, request_id, 2220 render_manager_.dom_ui()->ProcessDOMUIMessage(message, content, request_id,
2221 has_callback); 2221 has_callback);
(...skipping 366 matching lines...) Expand 10 before | Expand all | Expand 10 after
2588 2588
2589 default: 2589 default:
2590 NOTREACHED(); 2590 NOTREACHED();
2591 } 2591 }
2592 } 2592 }
2593 2593
2594 void TabContents::set_encoding(const std::string& encoding) { 2594 void TabContents::set_encoding(const std::string& encoding) {
2595 encoding_ = CharacterEncoding::GetCanonicalEncodingNameByAliasName(encoding); 2595 encoding_ = CharacterEncoding::GetCanonicalEncodingNameByAliasName(encoding);
2596 } 2596 }
2597 2597
OLDNEW
« no previous file with comments | « chrome/browser/tab_contents/tab_contents.h ('k') | chrome/common/render_messages_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698