Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 251087: add ENABLE_WEB_SOCKETS (Closed)

Created:
11 years, 2 months ago by ukai
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

add ENABLE_WEB_SOCKETS BUG=12497 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/features_override.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ukai
11 years, 2 months ago (2009-10-05 09:27:45 UTC) #1
darin (slow to review)
LGTM (assuming that the feature is disabled in some other way such that web pages ...
11 years, 2 months ago (2009-10-05 18:30:52 UTC) #2
Yuzo
LGTM. I have no comments to add.
11 years, 2 months ago (2009-10-06 04:18:43 UTC) #3
ukai
On 2009/10/05 18:30:52, darin wrote: > LGTM (assuming that the feature is disabled in some ...
11 years, 2 months ago (2009-10-06 08:54:30 UTC) #4
tyoshino (SeeGerritForStatus)
LGTM
11 years, 2 months ago (2009-10-06 09:38:50 UTC) #5
ukai
11 years, 2 months ago (2009-10-21 03:52:51 UTC) #6
On 2009/10/06 08:54:30, ukai wrote:
> On 2009/10/05 18:30:52, darin wrote:
> > LGTM (assuming that the feature is disabled in some other way such that web
> > pages could not be able to notice the difference)
> 
> For now, by enabling WEB_SOCKETS, it could be able to notice the difference
that
> "WebSocket" property found in window (i.e. "WebSocket" in window becomes
true.),
> although typeof window.WebSocket is undefined.
> Is it acceptable?

Now, webkit r49843 landed, web pages could not be able to notice the difference
without explicitly specifying --enable-web-sockets.

Powered by Google App Engine
This is Rietveld 408576698