Issue 251014: * Fix memory leaks caused by thread local data being lost....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251014: * Fix memory leaks caused by thread local data being lost.... (Closed)

Created:
11 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

* Fix memory leaks caused by thread local data being lost. * Rename some instance variables and accessors to fit code style. * Don't overwrite existing thread ID. Committed: http://code.google.com/p/v8/source/detail?r=2977

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -53 lines)			Patch
M	src/api.h	View	4 chunks	+44 lines, -31 lines	0 comments	Download
M	src/api.cc	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	src/bootstrapper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/debug.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/execution.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/regexp-stack.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/regexp-stack.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/top.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/top.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/v8threads.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/v8threads.cc	View	2 chunks	+15 lines, -1 line	0 comments	Download
M	test/cctest/test-log.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 2 months ago (2009-09-28 11:41:01 UTC) #2

LGTM,

however I find the use of Initialize function setting spare_ to NULL in the
thread archiving a bit confusing. How about remove the call to Initialize from
the HandleScopeImplementer constructor, and just initialize all members in the
constructor initializer list, and then change the name from Initialize to
"ReserAfterArchive" - or something like that.

Expand Messages | Collapse Messages