Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4235)

Unified Diff: chrome/browser/printing/print_job_unittest.cc

Issue 251012: Assert that thread-safe reference counting is used with... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_unittest.cc
===================================================================
--- chrome/browser/printing/print_job_unittest.cc (revision 27168)
+++ chrome/browser/printing/print_job_unittest.cc (working copy)
@@ -33,12 +33,6 @@
class TestOwner : public printing::PrintJobWorkerOwner {
public:
- virtual void AddRef() {
- EXPECT_FALSE(true);
- }
- virtual void Release() {
- EXPECT_FALSE(true);
- }
virtual void GetSettingsDone(const printing::PrintSettings& new_settings,
printing::PrintingContext::Result result) {
EXPECT_FALSE(true);
@@ -104,9 +98,9 @@
volatile bool check = false;
scoped_refptr<printing::PrintJob> job(new TestPrintJob(&check));
EXPECT_EQ(MessageLoop::current(), job->message_loop());
- TestOwner owner;
+ scoped_refptr<TestOwner> owner(new TestOwner);
TestSource source;
- job->Initialize(&owner, &source);
+ job->Initialize(owner, &source);
job->Stop();
job = NULL;
EXPECT_TRUE(check);
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698