Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2510001: Added InitTts function to speech synthesis library (Closed)

Created:
10 years, 6 months ago by Chaitanya
Modified:
9 years, 6 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Added InitTts function to speech synthesis library Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49260

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/cros/mock_speech_synthesis_library.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/speech_synthesis_library.h View 1 2 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/speech_synthesis_library.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Chaitanya
10 years, 6 months ago (2010-06-02 22:21:10 UTC) #1
oshima
can you check compilation error in the try bot? http://codereview.chromium.org/2510001/diff/1/4 File chrome/browser/chromeos/cros/speech_synthesis_library.h (right): http://codereview.chromium.org/2510001/diff/1/4#newcode26 chrome/browser/chromeos/cros/speech_synthesis_library.h:26: ...
10 years, 6 months ago (2010-06-02 22:49:53 UTC) #2
Chaitanya
http://codereview.chromium.org/2510001/diff/1/4 File chrome/browser/chromeos/cros/speech_synthesis_library.h (right): http://codereview.chromium.org/2510001/diff/1/4#newcode26 chrome/browser/chromeos/cros/speech_synthesis_library.h:26: // Checks if the engine is ready. On 2010/06/02 ...
10 years, 6 months ago (2010-06-02 22:57:24 UTC) #3
Chaitanya
This CL depends on 2471004. So I will not submit this until after 2471004 is ...
10 years, 6 months ago (2010-06-02 23:46:02 UTC) #4
oshima
ping me when 2471004 is in. On 2010/06/02 23:46:02, Chaitanya wrote: > This CL depends ...
10 years, 6 months ago (2010-06-07 18:28:40 UTC) #5
oshima
lgtm. make sure linux_chromeos bot does compile. On 2010/06/07 18:28:40, oshima wrote: > ping me ...
10 years, 6 months ago (2010-06-08 02:12:40 UTC) #6
Nikita (slow)
Please make sure that trybots are green before committing next time. This CL broke build.
10 years, 6 months ago (2010-06-09 16:28:13 UTC) #7
Chaitanya
10 years, 6 months ago (2010-06-09 17:08:25 UTC) #8
On 2010/06/09 16:28:13, Nikita Kostylev wrote:
> Please make sure that trybots are green before committing next time.
> This CL broke build.

Sorry about that. I thought I was looking at the try bots, but clearly I messed
something up. Will take care henceforth.

Powered by Google App Engine
This is Rietveld 408576698