Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2501002: Quick fix to avoid crashing in unit tests when HTTPTestServer::CreateServer r... (Closed)

Created:
10 years, 6 months ago by michaeln
Modified:
9 years, 7 months ago
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Quick fix to avoid crashing in unit tests when HTTPTestServer::CreateServer returns NULL. BUG=45664 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48764

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M webkit/appcache/appcache_update_job_unittest.cc View 1 3 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
michaeln
please take a look
10 years, 6 months ago (2010-06-02 19:31:31 UTC) #1
willchan no longer on Chromium
10 years, 6 months ago (2010-06-02 20:13:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698