Chromium Code Reviews

Issue 2501001: Update dialog parent handling logic. (Closed)

Created:
10 years, 6 months ago by xiyuan
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org, Daniel Erat
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Update dialog parent handling logic. - Use real transient parent for hosted native dialogs since window manager supports transient of transient now; - Use last active normal browser window as parent for option dialogs since we don't want to use panel popups as parent; BUG=chromium-os:3708 TEST=none. This CL gives real transent parent for dialogs but we still need to way to show the dialogs, either exit fullscreen or put them on top of fullscreen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48773

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Stats (+37 lines, -7 lines)
M chrome/browser/chromeos/options/options_window_view.cc View 1 chunk +10 lines, -2 lines 3 comments
M chrome/browser/gtk/gtk_util.h View 1 chunk +4 lines, -0 lines 0 comments
M chrome/browser/gtk/gtk_util.cc View 5 chunks +19 lines, -3 lines 0 comments
M chrome/browser/gtk/keyword_editor_view.cc View 2 chunks +4 lines, -2 lines 0 comments

Messages

Total messages: 4 (0 generated)
xiyuan
10 years, 6 months ago (2010-06-02 17:31:00 UTC) #1
sky
LGTM http://codereview.chromium.org/2501001/diff/1/2 File chrome/browser/chromeos/options/options_window_view.cc (right): http://codereview.chromium.org/2501001/diff/1/2#newcode312 chrome/browser/chromeos/options/options_window_view.cc:312: b = BrowserList::FindBrowserWithType(b->profile(), FindBrowserWithType searches in order of ...
10 years, 6 months ago (2010-06-02 17:44:12 UTC) #2
xiyuan
http://codereview.chromium.org/2501001/diff/1/2 File chrome/browser/chromeos/options/options_window_view.cc (right): http://codereview.chromium.org/2501001/diff/1/2#newcode312 chrome/browser/chromeos/options/options_window_view.cc:312: b = BrowserList::FindBrowserWithType(b->profile(), On 2010/06/02 17:44:12, sky wrote: > ...
10 years, 6 months ago (2010-06-02 17:48:08 UTC) #3
sky
10 years, 6 months ago (2010-06-02 17:52:21 UTC) #4
http://codereview.chromium.org/2501001/diff/1/2
File chrome/browser/chromeos/options/options_window_view.cc (right):

http://codereview.chromium.org/2501001/diff/1/2#newcode312
chrome/browser/chromeos/options/options_window_view.cc:312: b =
BrowserList::FindBrowserWithType(b->profile(),
On 2010/06/02 17:48:08, xiyuan wrote:
> On 2010/06/02 17:44:12, sky wrote:
> > FindBrowserWithType searches in order of activation, so you can just use it
> > instead of first asking for GetLastActive.
> The reason for doing this is FindBrowserWithType expects a profile and I don't
> have that. :(
> 

Ah ok. That makes sense.

Powered by Google App Engine