Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Issue 2498003: Revert r48735 "Added user image screen for new user login (or old user logging in through" (Closed)

Created:
10 years, 6 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
whywhat, Evan Stade
CC:
chromium-reviews, Paweł Hajdan Jr., Paul Godavari, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Revert r48735 "Added user image screen for new user login (or old user logging in through" This reverts commit 4ffcb495af72106fe243c6982119d799325d86ba. The following tests were failing with this change. NetworkScreenTest.Basic NetworkScreenTest.NetworksConnectedNotSelected NetworkScreenTest.EthernetSelected NetworkScreenTest.WifiSelected NetworkScreenTest.CellularSelected NetworkScreenTest.WifiWaiting LoginScreenTest.TestBasic LoginScreenTest.AuthenticationFailed LoginScreenTest.IncognitoLogin grd files are excluded from revert to avoid build failures. TBR=avayvod@chromium.org BUG=none TEST=chromeos build bot should cycle green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48761

Patch Set 1 #

Patch Set 2 : removed grd files from cl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1143 lines) Patch
D chrome/browser/chromeos/login/camera.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/chromeos/login/camera.cc View 1 chunk +0 lines, -410 lines 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 5 chunks +3 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/login/mock_authenticator.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/screen_observer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.h View 1 chunk +1 line, -2 lines 0 comments Download
chrome/browser/chromeos/login/user_image_downloader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/login/user_image_screen.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/login/user_image_screen.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/chromeos/login/user_image_view.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/chromeos/login/user_image_view.cc View 1 chunk +0 lines, -226 lines 0 comments Download
chrome/browser/chromeos/login/user_manager.cc View 3 chunks +14 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 5 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 14 chunks +3 lines, -56 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
lgtm. ¡muchas gracias!
10 years, 6 months ago (2010-06-02 20:47:44 UTC) #1
oshima
10 years, 6 months ago (2010-06-02 20:52:49 UTC) #2
whywhat
10 years, 6 months ago (2010-06-03 11:13:08 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698