Issue 2496002: Fixing mounting so that it remounts any devices it finds on boot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2496002: Fixing mounting so that it remounts any devices it finds on boot. (Closed)

Created:
10 years, 6 months ago by dhg

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixing mounting so that it remounts any devices it finds on boot. BUG=chromium-os:3715 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48790

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
M	chrome/browser/browser_init.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/mount_library.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/usb_mount_observer.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/usb_mount_observer.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

xiyuan

10 years, 6 months ago (2010-06-02 19:47:44 UTC) #2

LGTM

http://codereview.chromium.org/2496002/diff/1/5
File chrome/browser/chromeos/usb_mount_observer.h (right):

http://codereview.chromium.org/2496002/diff/1/5#newcode56
chrome/browser/chromeos/usb_mount_observer.h:56: 
nit: Please remove the extra empty lines.

Expand Messages | Collapse Messages