Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 249054: Add ellipses to |Add| and |Edit| buttons of Search engine manager(keyword view), since they opens an (Closed)

Created:
11 years, 2 months ago by tfarina (gmail-do not use)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add ellipses to |Add| and |Edit| buttons of Search engine manager(keyword view), since they opens another window and does not, for example, add or edit the selected item. BUG=16380 TEST=Open the search engine manager and see if the |Add| and the |Edit| button has the "..." in the end. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28054

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina (gmail-do not use)
11 years, 2 months ago (2009-10-01 12:46:31 UTC) #1
Finnur
Why not do this for the Edit button also? On 2009/10/01 12:46:31, tfarina wrote: >
11 years, 2 months ago (2009-10-01 22:54:30 UTC) #2
tfarina (gmail-do not use)
On 2009/10/01 22:54:30, Finnur wrote: > Why not do this for the Edit button also? ...
11 years, 2 months ago (2009-10-02 20:20:52 UTC) #3
Finnur
LG On 2009/10/02 20:20:52, tfarina wrote: > On 2009/10/01 22:54:30, Finnur wrote: > > Why ...
11 years, 2 months ago (2009-10-02 20:23:57 UTC) #4
tfarina (gmail-do not use)
11 years, 2 months ago (2009-10-05 21:45:41 UTC) #5 
On 2009/10/02 20:23:57, Finnur wrote:
>LG
Hi Finnur, could you land this to me?

Powered by Google App Engine
This is Rietveld 408576698