Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 249039: Two changes, one a refactoring and one that affects V8's JS semantics.... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Two changes, one a refactoring and one that affects V8's JS semantics. 1. Change the AST node type CallNew to be a subclass of Expression rather than Call. It's not really a call but it just happens to have the same fields. 2. Change our error reporting for invalid left-hand sides in for-in statements, pre- and postfix count expressions, and assignments. Before we signaled a syntax error at compile time *unless* the LHS was a function call or 'new' expression, in which case we signaled a reference error at runtime. Now we signal a reference error at runtime in all cases. This matches the JSC behavior in Safari 4. Committed: http://code.google.com/p/v8/source/detail?r=2994

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -138 lines) Patch
M src/ast.h View 2 chunks +13 lines, -8 lines 0 comments Download
M src/parser.cc View 1 4 chunks +39 lines, -84 lines 0 comments Download
M src/usage-analyzer.cc View 2 chunks +8 lines, -39 lines 0 comments Download
M test/mjsunit/invalid-lhs.js View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-09-30 09:36:37 UTC) #1
Mads Ager (chromium)
11 years, 2 months ago (2009-09-30 09:41:11 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698