Issue 249013: Fixed Mac gyp build. Switched to using Chrome hash_tables.h, changed...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249013: Fixed Mac gyp build. Switched to using Chrome hash_tables.h, changed... (Closed)

Created:
11 years, 2 months ago by Ken Russell (Google)

Modified:
9 years, 7 months ago

Reviewers:
maf

CC:
o3d-review_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fixed Mac gyp build. Switched to using Chrome hash_tables.h, changed how hash functions are specified for certain key types, and deleted our std_hash.h. Fixed forward reference bug in cmd_buffer_format.h. Built and tested on Windows and Mac. Remaining workarounds: enabled C++ exceptions due to use of Objective C try/catch in plugin_mac.mm; disabled warnings as errors due to signed / unsigned issues in command buffer code, which will probably need to be fixed by changing typedefs and argument types. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27311

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -184 lines)			Patch
D	base/cross/std_hash.h	View	1	1 chunk	+0 lines, -165 lines	0 comments	Download
M	build/common.gypi	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	command_buffer/command_buffer.gyp	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	command_buffer/common/cross/cmd_buffer_format.h	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	plugin/cross/np_v8_bridge.h	View	1	3 chunks	+26 lines, -9 lines	0 comments	Download
M	plugin/cross/o3d_glue.h	View	1	3 chunks	+39 lines, -4 lines	0 comments	Download
M	tests/tests.gyp	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages