Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 249005: If IE was navigated away to a different page when the ChromeFrame inspector w... (Closed)

Created:
11 years, 2 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

If IE was navigated away to a different page when the ChromeFrame inspector window was open it would crash the browser. The fix is to ensure that the inspector window is closed when the ExternalTabContainer window is uninitialized. This fixes bug http://code.google.com/p/chromium/issues/detail?id=22993 Bug=22993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/external_tab_container.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 2 months ago (2009-09-25 21:23:12 UTC) #1
amit
11 years, 2 months ago (2009-09-25 23:08:22 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698