Fix gclient_smoketest for svn 1.5 and python 2.5

Fix gclient_smoketest for svn 1.5 and python 2.5

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48688

[Mandeep Singh Baines, 2010-06-02 01:33:00]

LGTM

But this does all seem a bit fragile. But I guess that's what the ToDos are for.

http://codereview.chromium.org/2487003/diff/1/2
File tests/fake_repos.py (right):

http://codereview.chromium.org/2487003/diff/1/2#newcode178
tests/fake_repos.py:178: to_add.append(item[7:].strip())
This seems fragile. How about:

item.split()[1]

The downside with that is that you don't quoted strings properly but that should
be OK. None of the test code uses that.

[M-A Ruel, 2010-06-02 01:38:50]

On 2010/06/02 01:33:00, Mandeep Singh Baines wrote:
> LGTM
> 
> But this does all seem a bit fragile. But I guess that's what the ToDos are
for.
> 
> http://codereview.chromium.org/2487003/diff/1/2
> File tests/fake_repos.py (right):
> 
> http://codereview.chromium.org/2487003/diff/1/2#newcode178
> tests/fake_repos.py:178: to_add.append(item[7:].strip())
> This seems fragile. How about:
> 
> item.split()[1]
> 
> The downside with that is that you don't quoted strings properly but that
should
> be OK. None of the test code uses that.

I'll reuse scm.py code instead tomorrow so at least this mess will go away, the
code thing is that it'll increase coverage. :)

For the actual output, I don't want to be too strict on the actual output, I'll
probably just add a member function to check for a range...