Disable navigation contextual menus for Sync dialog UI....

Disable navigation contextual menus for Sync dialog UI.

BUG=30710, 30706
TEST=Invoke a contextual menu in the Sync sign-in dialog, navigation items
should not appear.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48781

[csilv, 2010-06-02 05:09:50]

+estade for review
Evan, minor bug fix for two issues in the bug database.  Your name shows up most
frequently in the logs, so I figured you would be the best person for a code
review.  thx!

[Evan Stade, 2010-06-02 17:52:43]

http://codereview.chromium.org/2487002/diff/1/2
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/2487002/diff/1/2#newcode305
chrome/browser/tab_contents/render_view_context_menu.cc:305: is_sync =
IsSyncResourcesURL(params_.frame_url);
is this supposed to read page_url? If frame_url is correct, can you put this
line on L292?

[csilv, 2010-06-02 17:59:51]

http://codereview.chromium.org/2487002/diff/1/2
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/2487002/diff/1/2#newcode305
chrome/browser/tab_contents/render_view_context_menu.cc:305: is_sync =
IsSyncResourcesURL(params_.frame_url);
On 2010/06/02 17:52:43, Evan Stade wrote:
> is this supposed to read page_url? If frame_url is correct, can you put this
> line on L292?

Grr, yes, thanks for catching my stupid bug.  Fixed.

[Evan Stade, 2010-06-02 18:03:53]

http://codereview.chromium.org/2487002/diff/5002/6001
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/2487002/diff/5002/6001#newcode292
chrome/browser/tab_contents/render_view_context_menu.cc:292: bool is_sync =
false;
it's confusing that this is declared in this scope but never used at this scope.
Can we get rid of the variable and use the function call directly in the
conditional?

(note that is_devtools is actually used further down, which is what I would
assume after seeing it declared out here)

[csilv, 2010-06-02 18:09:55]

http://codereview.chromium.org/2487002/diff/5002/6001
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

http://codereview.chromium.org/2487002/diff/5002/6001#newcode292
chrome/browser/tab_contents/render_view_context_menu.cc:292: bool is_sync =
false;
You bet.  Done.

[Evan Stade, 2010-06-02 18:38:32]

LGTM.