Truncate very long javascript alert messages. They can overflow the UI and on Linux cause crashes.

Truncate very long javascript alert messages. They can overflow the UI and on Linux cause crashes.

BUG=45002
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48751

[zel, 2010-06-02 01:41:41]

http://codereview.chromium.org/2486003/diff/1/2
File chrome/browser/js_modal_dialog.cc (right):

http://codereview.chromium.org/2486003/diff/1/2#newcode42
chrome/browser/js_modal_dialog.cc:42: message_text_ = message_text_.substr(0,
kMessageTextMaxSize);
You should use ElideString() from string_util.h instead of substr() for string
shortening here.

http://codereview.chromium.org/2486003/diff/1/2#newcode45
chrome/browser/js_modal_dialog.cc:45: 0, kDefaultPromptTextSize);
same as above

[Elliot Glaysher, 2010-06-02 17:27:40]

On 2010/06/02 01:41:41, zel wrote:
> You should use ElideString() from string_util.h instead of substr() for string
> shortening here.

Done

[zel, 2010-06-02 17:43:32]

LGTM