Issue 248033: Return the original value when assigning to a pixel array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248033: Return the original value when assigning to a pixel array (Closed)

Created:
11 years, 2 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Return the original value when assigning to a pixel array. After fast-case assignment to a pixel array the original value assigned is now returned. Before the un-tagged smi value was returned causing crashes. BUG=22913 TEST=cctest/test-api/PixelArray Committed: http://code.google.com/p/v8/source/detail?r=2985

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -0 lines)			Patch
	M	src/ia32/ic-ia32.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
	M	test/cctest/test-api.cc	View		2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

Fast case pixel array in not implemented on x64 or ARM.

11 years, 2 months ago (2009-09-29 14:42:02 UTC) #1

Mads Ager (chromium)

11 years, 2 months ago (2009-09-29 14:52:32 UTC) #2

LGTM.  We should implement this on at least X64!

Expand Messages | Collapse Messages