Make the try slave selection client side.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 import exceptions
 import os
 import StringIO
@@ skipping 13 matching lines @@
   if not input_api.change.NOSUCHKEY:
     return [output_api.PresubmitError("!!")]
   elif not input_api.change.REALLYNOSUCHKEY:
     return [output_api.PresubmitPromptWarning("??")]
   elif not input_api.change.REALLYABSOLUTELYNOSUCHKEY:
     return [output_api.PresubmitPromptWarning("??"),
             output_api.PresubmitError("XX!!XX")]
   else:
     return ()
 """
+  presubmit_tryslave = """
+def GetPreferredTrySlaves():
+  return %s
+"""
 
   def setUp(self):
     super_mox.SuperMoxTestBase.setUp(self)
     self.mox.StubOutWithMock(presubmit, 'warnings')
     # Stub out 'os' but keep os.path.commonprefix/dirname/join/normpath/splitext
     # and os.sep.
     os_sep = presubmit.os.sep
     os_path_commonprefix = presubmit.os.path.commonprefix
     os_path_dirname = presubmit.os.path.dirname
     os_path_join = presubmit.os.path.join
@@ skipping 22 matching lines @@
     self.mox.StubOutWithMock(presubmit.gclient_scm, 'CaptureSVNInfo')
     self.mox.StubOutWithMock(presubmit.gcl, 'GetSVNFileProperty')
     self.mox.StubOutWithMock(presubmit.gcl, 'ReadFile')
 
 
 class PresubmitUnittest(PresubmitTestsBase):
   """General presubmit_support.py tests (excluding InputApi and OutputApi)."""
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
-      'AffectedFile', 'Change', 'DoPresubmitChecks', 'GitChange',
-      'GitAffectedFile', 'InputApi',
+      'AffectedFile', 'Change', 'DoGetTrySlaves', 'DoPresubmitChecks',
+      'GetTrySlavesExecuter', 'GitChange', 'GitAffectedFile', 'InputApi',
       'ListRelevantPresubmitFiles', 'Main', 'NotImplementedException',
       'OutputApi', 'ParseFiles', 'PresubmitExecuter', 'ScanSubDirs',
       'SvnAffectedFile', 'SvnChange',
       'cPickle', 'cStringIO', 'exceptions',
       'fnmatch', 'gcl', 'gclient_scm', 'glob', 'logging', 'marshal', 'normpath',
       'optparse', 'os', 'pickle',
       'presubmit_canned_checks', 'random', 're', 'subprocess', 'sys', 'time',
       'tempfile', 'traceback', 'types', 'unittest', 'urllib2', 'warnings',
     ]
     # If this test fails, you should add the relevant test.
@@ skipping 389 matching lines @@
         'foo', "Blah Blah\n\nSTORY=http://tracker.com/42\nBUG=boo\n",
         self.fake_root_dir, None, 0, 0)
     self.failUnless(presubmit.DoPresubmitChecks(change, False, True, output,
                                                 input, DEFAULT_SCRIPT, False))
     self.assertEquals(output.getvalue(),
                       ('Warning, no presubmit.py found.\n'
                        'Running default presubmit script.\n'
                        '** Presubmit Messages **\n'
                        'http://tracker.com/42\n\n'))
 
+  def testGetTrySlavesExecuter(self):
+    self.mox.ReplayAll()
+
+    executer = presubmit.GetTrySlavesExecuter()
+    self.assertEqual([], executer.ExecPresubmitScript(''))
+    self.assertEqual([], executer.ExecPresubmitScript('def foo():\n  return\n'))
+
+    # bad results
+    starts_with_space_result = ['  starts_with_space']
+    not_list_result1 = "'foo'"
+    not_list_result2 = "('a', 'tuple')"
+    for result in starts_with_space_result, not_list_result1, not_list_result2:
+      self.assertRaises(exceptions.RuntimeError,
+                        executer.ExecPresubmitScript,
+                        self.presubmit_tryslave % result)
+
+    # good results
+    expected_result = ['1', '2', '3']
+    empty_result = []
+    space_in_name_result = ['foo bar', '1\t2 3']
+    for result in expected_result, empty_result, space_in_name_result:
+      self.assertEqual(result,
+                       executer.ExecPresubmitScript(self.presubmit_tryslave %
+                                                    str(result)))
+
+  def testDoGetTrySlaves(self):
+    join = presubmit.os.path.join
+    filename = 'foo.cc'
+    filename_linux = join('linux_only', 'penguin.cc')
+    root_presubmit = join(self.fake_root_dir, 'PRESUBMIT.py')
+    linux_presubmit = join(self.fake_root_dir, 'linux_only', 'PRESUBMIT.py')
+
+    presubmit.os.path.isfile(root_presubmit).AndReturn(True)
+    presubmit.gcl.ReadFile(root_presubmit, 'rU').AndReturn(
+        self.presubmit_tryslave % '["win"]')
+
+    presubmit.os.path.isfile(root_presubmit).AndReturn(True)
+    presubmit.os.path.isfile(linux_presubmit).AndReturn(True)
+    presubmit.gcl.ReadFile(root_presubmit, 'rU').AndReturn(
+        self.presubmit_tryslave % '["win"]')
+    presubmit.gcl.ReadFile(linux_presubmit, 'rU').AndReturn(
+        self.presubmit_tryslave % '["linux"]')
+    self.mox.ReplayAll()
+
+    output = StringIO.StringIO()
+    self.assertEqual(['win'],
+                     presubmit.DoGetTrySlaves([filename], self.fake_root_dir,
+                                              None, False, output))
+    output = StringIO.StringIO()
+    self.assertEqual(['win', 'linux'],
+                     presubmit.DoGetTrySlaves([filename, filename_linux],
+                                              self.fake_root_dir, None, False,
+                                              output))
+
   def testMain(self):
     self.mox.StubOutWithMock(presubmit, 'DoPresubmitChecks')
     self.mox.StubOutWithMock(presubmit, 'ParseFiles')
     presubmit.os.path.isdir(presubmit.os.path.join(self.fake_root_dir, '.git')
         ).AndReturn(False)
     presubmit.os.path.isdir(presubmit.os.path.join(self.fake_root_dir, '.svn')
         ).AndReturn(False)
     #presubmit.ParseFiles([], None).AndReturn([])
     presubmit.DoPresubmitChecks(mox.IgnoreArg(), False, False,
                                 mox.IgnoreArg(),
@@ skipping 915 matching lines @@
     process.communicate().AndReturn(('', ''))
     self.mox.ReplayAll()
 
     results = presubmit_canned_checks.RunPythonUnitTests(
         input_api, presubmit.OutputApi, ['test_module'])
     self.assertEquals(len(results), 0)
 
 
 if __name__ == '__main__':
   unittest.main()