Issue 248006: Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248006: Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS. (Closed)

Created:
11 years, 3 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS. GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors. BUG=23031 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27368

Patch Set 1 #

Total comments: 2

Patch Set 2 : Listen for notification after sending CSS #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
	M	chrome/browser/extensions/extension_host.cc	View	1	2 chunks	+15 lines, -5 lines	0 comments	Download
	M	chrome/browser/gtk/extension_shelf_gtk.cc	View		4 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

http://codereview.chromium.org/248006/diff/1/2 File chrome/browser/extensions/extension_host.cc (right): http://codereview.chromium.org/248006/diff/1/2#newcode131 Line 131: registrar_.Add(this, NotificationType::BROWSER_THEME_CHANGED, Not sure if NavigateToURL is the ...

11 years, 3 months ago (2009-09-25 21:27:19 UTC) #2

Elliot Glaysher

11 years, 3 months ago (2009-09-25 21:50:01 UTC) #3

LGTM

Expand Messages | Collapse Messages