Issue 2475003: Fix bug in test case that made it fail to compile in non-debug mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2475003: Fix bug in test case that made it fail to compile in non-debug mode. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Fix bug in test case that made it fail to compile in non-debug mode. Using ASSERT_EQ instead of CHECK_EQ means that a variable becomes unused.

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	test/cctest/test-strings.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Søren Thygesen Gjesse

10 years, 6 months ago (2010-06-02 11:05:14 UTC) #3

On 2010/06/02 11:04:45, Søren Gjesse wrote:
> LGTM

Maybe we should check all test-xxx.cc files for ASSERT.