ffmpeg delete source folder and use deps to pull in all content....

ffmpeg roll to deps version that contains gyp and source
BUG=42238
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48697

[fbarchard, 2010-06-01 17:52:43]

Remove all content from src/third_patch/ffmpeg and use DEPS to pull it all in
from deps/third_party/ffmpeg/source instead.

(NOTE build will be red until deps is committed)

[scherkus (not reviewing), 2010-06-01 21:33:07]

Just to confirm we need to move everything over to /deps before this change is
committed, right?

[fbarchard, 2010-06-01 21:43:29]

correct.  This simultaneously deletes the src/third_party and updates it using
DEPS from deps/third_party.  In theory anyway.

[fbarchard, 2010-06-01 23:47:08]

Updated to roll to 48678 which is the cleaned up ffmpeg with config and
patched-ffmpeg-mt moved up one level, and binaries removed.

[scherkus (not reviewing), 2010-06-02 00:48:13]

I'm not seeing a try server run associated with this CL -- it could be that
rietveld is messed up.

I also can't seem to view the diff to the DEPS file.

[fbarchard, 2010-06-02 01:23:58]

Testing the atomic deps+src change is proving tricky.
Try reviewing again.  I've recreated the CL

[scherkus (not reviewing), 2010-06-02 02:01:08]

so is this CL obsolete or is there another one lurking around?

[fbarchard, 2010-06-02 02:42:15]

This is the correct review.  I'm not sure why the try server isnt running it. 
It gets started and then disappears.
email says it built at least once successfully, so I'm fairly confident.

[scherkus (not reviewing), 2010-06-02 02:55:18]

I can't click on any of the files for review.

they're also missing their subversion status (A, M, D, etc...)

[fbarchard, 2010-06-02 03:05:17]

works for me.  weird.  The current code is passing a linux build.
Here is the content of this change.
--- Changelist ffmpeg_deps_based_source:
D      third_party\ffmpeg
D      third_party\ffmpeg\README.chromium
D      third_party\ffmpeg\source
D      third_party\ffmpeg\source\config
D      third_party\ffmpeg\source\config\ChromeOS
D      third_party\ffmpeg\source\config\ChromeOS\linux
D      third_party\ffmpeg\source\config\ChromeOS\linux\arm
D      third_party\ffmpeg\source\config\ChromeOS\linux\arm\config.h
D      third_party\ffmpeg\source\config\ChromeOS\linux\x64
D      third_party\ffmpeg\source\config\ChromeOS\linux\x64\config.h
D      third_party\ffmpeg\source\config\ChromeOS\linux\arm-neon
D      third_party\ffmpeg\source\config\ChromeOS\linux\arm-neon\config.h
D      third_party\ffmpeg\source\config\ChromeOS\linux\ia32
D      third_party\ffmpeg\source\config\ChromeOS\linux\ia32\config.h
D      third_party\ffmpeg\source\config\Chromium
D      third_party\ffmpeg\source\config\Chromium\linux
D      third_party\ffmpeg\source\config\Chromium\linux\arm
D      third_party\ffmpeg\source\config\Chromium\linux\arm\config.h
D      third_party\ffmpeg\source\config\Chromium\linux\x64
D      third_party\ffmpeg\source\config\Chromium\linux\x64\config.h
D      third_party\ffmpeg\source\config\Chromium\linux\arm-neon
D      third_party\ffmpeg\source\config\Chromium\linux\arm-neon\config.h
D      third_party\ffmpeg\source\config\Chromium\linux\ia32
D      third_party\ffmpeg\source\config\Chromium\linux\ia32\config.h
D      third_party\ffmpeg\source\config\Chromium\mac
D      third_party\ffmpeg\source\config\Chromium\mac\ia32
D      third_party\ffmpeg\source\config\Chromium\mac\ia32\config.h
D      third_party\ffmpeg\source\config\Chromium\win
D      third_party\ffmpeg\source\config\Chromium\win\ia32
D      third_party\ffmpeg\source\config\Chromium\win\ia32\config.h
D      third_party\ffmpeg\source\config\ChromiumOS
D      third_party\ffmpeg\source\config\ChromiumOS\linux
D      third_party\ffmpeg\source\config\ChromiumOS\linux\arm
D      third_party\ffmpeg\source\config\ChromiumOS\linux\arm\config.h
D      third_party\ffmpeg\source\config\ChromiumOS\linux\x64
D      third_party\ffmpeg\source\config\ChromiumOS\linux\x64\config.h
D      third_party\ffmpeg\source\config\ChromiumOS\linux\arm-neon
D      third_party\ffmpeg\source\config\ChromiumOS\linux\arm-neon\config.h
D      third_party\ffmpeg\source\config\ChromiumOS\linux\ia32
D      third_party\ffmpeg\source\config\ChromiumOS\linux\ia32\config.h
D      third_party\ffmpeg\source\config\libavutil
D      third_party\ffmpeg\source\config\libavutil\avconfig.h
D      third_party\ffmpeg\source\config\Chrome
D      third_party\ffmpeg\source\config\Chrome\linux
D      third_party\ffmpeg\source\config\Chrome\linux\arm
D      third_party\ffmpeg\source\config\Chrome\linux\arm\config.h
D      third_party\ffmpeg\source\config\Chrome\linux\x64
D      third_party\ffmpeg\source\config\Chrome\linux\x64\config.h
D      third_party\ffmpeg\source\config\Chrome\linux\arm-neon
D      third_party\ffmpeg\source\config\Chrome\linux\arm-neon\config.h
D      third_party\ffmpeg\source\config\Chrome\linux\ia32
D      third_party\ffmpeg\source\config\Chrome\linux\ia32\config.h
D      third_party\ffmpeg\source\config\Chrome\mac
D      third_party\ffmpeg\source\config\Chrome\mac\ia32
D      third_party\ffmpeg\source\config\Chrome\mac\ia32\config.h
D      third_party\ffmpeg\source\config\Chrome\win
D      third_party\ffmpeg\source\config\Chrome\win\ia32
D      third_party\ffmpeg\source\config\Chrome\win\ia32\config.h
D      third_party\ffmpeg\ffmpeg.gyp
D      third_party\ffmpeg\munge_config_optimizations.sh
D      third_party\ffmpeg\include
D      third_party\ffmpeg\include\libavformat
D      third_party\ffmpeg\include\libavcodec
D      third_party\ffmpeg\include\libavutil
D      third_party\ffmpeg\include\libavdevice
D      third_party\ffmpeg\include\win
D      third_party\ffmpeg\include\win\inttypes.h
D      third_party\ffmpeg\include\win\stdint.h
D      third_party\ffmpeg\avformat-52.sigs
D      third_party\ffmpeg\dummy_nolink.cc
D      third_party\ffmpeg\avutil-50.sigs
D      third_party\ffmpeg\generate_libs.py
D      third_party\ffmpeg\binaries
D      third_party\ffmpeg\avcodec-52.sigs
D      third_party\ffmpeg\ffmpeg_stub_headers.fragment
M      DEPS

Index: DEPS
===================================================================
--- DEPS        (revision 48686)
+++ DEPS        (working copy)
@@ -2,7 +2,7 @@
   "webkit_trunk":
   "http://svn.webkit.org/repository/webkit/trunk",
   "webkit_revision": "60469",
-  "ffmpeg_revision": "47712",
+  "ffmpeg_revision": "48686",
   "skia_revision": "562",
   "chromium_git": "http://src.chromium.org/git",
   "swig_revision": "40423",
@@ -139,8 +139,8 @@
   "src/third_party/swig/Lib":
     "/trunk/deps/third_party/swig/Lib@" + Var("swig_revision"),

-  "src/third_party/ffmpeg/source/patched-ffmpeg-mt":
-    "/trunk/deps/third_party/ffmpeg/patched-ffmpeg-mt@" +
+  "src/third_party/ffmpeg":
+    "/trunk/deps/third_party/ffmpeg/source@" +
     Var("ffmpeg_revision"),

   "src/third_party/libvpx/include":


On Tue, Jun 1, 2010 at 7:55 PM, <scherkus@chromium.org> wrote:

> I can't click on any of the files for review.
>
> they're also missing their subversion status (A, M, D, etc...)
>
>
> http://codereview.chromium.org/2475001/show
>

[scherkus (not reviewing), 2010-06-02 03:12:44]

strange... in any case DEPS looks good!

LGTM assuming it'll all work correctly

before checking in I would give a heads up to maruel and nsylvain in case the
bots need to clobber check out

in fact we may want to check this in late PM to make sure it goes smoothly
without wasting everyones time due to tree closures