Issue 2471006: Refactored MediatorThread to use Chrome threads primarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2471006: Refactored MediatorThread to use Chrome threads primarily. (Closed)

Created:
10 years, 6 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, idana, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, tim (not reviewing)

Visibility:
Public.

Description

Refactored MediatorThread to use Chrome threads primarily. This is in preparation for using Chrome sockets. Made TalkMediator explicitly non-thread-safe. BUG=45612 TEST=manual testing of notifications Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48791

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+285 lines, -259 lines)			Patch
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	5 chunks	+13 lines, -11 lines	0 comments	Download
M	chrome/common/net/notifier/communicator/login_failure.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/common/net/notifier/listener/mediator_thread_impl.h	View	4 chunks	+45 lines, -71 lines	0 comments	Download
M	chrome/common/net/notifier/listener/mediator_thread_impl.cc	View	10 chunks	+178 lines, -110 lines	0 comments	Download
M	chrome/common/net/notifier/listener/talk_mediator_impl.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/common/net/notifier/listener/talk_mediator_impl.cc	View	8 chunks	+40 lines, -55 lines	0 comments	Download
M	chrome/common/net/notifier/listener/talk_mediator_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pretty cool!
LGTM

Expand Messages | Collapse Messages