src/ia32/ic-ia32.cc - Issue 2470001: Change keyed load IC interface on x64 to pass arguments in registers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 2470001: Change keyed load IC interface on x64 to pass arguments in registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/ic-ia32.cc

===================================================================

--- src/ia32/ic-ia32.cc (revision 4786)

+++ src/ia32/ic-ia32.cc (working copy)

@@ -454,11 +454,10 @@

__ mov(edi,

Operand::StaticArray(ecx, times_pointer_size, cache_field_offsets));

__ movzx_b(ecx, FieldOperand(ebx, Map::kInObjectPropertiesOffset));

- __ cmp(edi, Operand(ecx));

+ __ sub(edi, Operand(ecx));

__ j(above_equal, &slow);

// Load in-object property.

- __ sub(edi, Operand(ecx));

__ movzx_b(ecx, FieldOperand(ebx, Map::kInstanceSizeOffset));

__ add(ecx, Operand(edi));

__ mov(eax, FieldOperand(edx, ecx, times_pointer_size, 0));

@@ -690,7 +689,7 @@

__ fincstp();

// Fall through to slow case.

- // Slow case: Load key and receiver from stack and jump to runtime.

+ // Slow case: Jump to runtime.

__ bind(&slow);

__ IncrementCounter(&Counters::keyed_load_external_array_slow, 1);

GenerateRuntimeGetProperty(masm);

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »