Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: src/x64/debug-x64.cc

Issue 2470001: Change keyed load IC interface on x64 to pass arguments in registers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // -- rax: number of arguments 117 // -- rax: number of arguments
118 // ----------------------------------- 118 // -----------------------------------
119 // The number of arguments in rax is not smi encoded. 119 // The number of arguments in rax is not smi encoded.
120 Generate_DebugBreakCallHelper(masm, 0, false); 120 Generate_DebugBreakCallHelper(masm, 0, false);
121 } 121 }
122 122
123 123
124 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 124 void Debug::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
125 // Register state for keyed IC load call (from ic-x64.cc). 125 // Register state for keyed IC load call (from ic-x64.cc).
126 // ----------- S t a t e ------------- 126 // ----------- S t a t e -------------
127 // No registers used on entry. 127 // -- rax : key
128 // -- rdx : receiver
128 // ----------------------------------- 129 // -----------------------------------
129 Generate_DebugBreakCallHelper(masm, 0, false); 130 Generate_DebugBreakCallHelper(masm, rax.bit() | rdx.bit(), false);
130 } 131 }
131 132
132 133
133 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 134 void Debug::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
134 // Register state for keyed IC load call (from ic-x64.cc). 135 // Register state for keyed IC load call (from ic-x64.cc).
135 // ----------- S t a t e ------------- 136 // ----------- S t a t e -------------
136 // -- rax : value 137 // -- rax : value
137 // -- rcx : key 138 // -- rcx : key
138 // -- rdx : receiver 139 // -- rdx : receiver
139 // ----------------------------------- 140 // -----------------------------------
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
214 Assembler::kCallInstructionLength); 215 Assembler::kCallInstructionLength);
215 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(), 216 rinfo()->PatchCodeWithCall(Debug::debug_break_return()->entry(),
216 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength); 217 Assembler::kJSReturnSequenceLength - Assembler::kCallInstructionLength);
217 } 218 }
218 219
219 #endif // ENABLE_DEBUGGER_SUPPORT 220 #endif // ENABLE_DEBUGGER_SUPPORT
220 221
221 } } // namespace v8::internal 222 } } // namespace v8::internal
222 223
223 #endif // V8_TARGET_ARCH_X64 224 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698