Issue 2468002: Generate .dSYM bundles for loadable_modules as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2468002: Generate .dSYM bundles for loadable_modules as well. (Closed)

Created:
10 years, 6 months ago by jam

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Generate .dSYM bundles for loadable_modules as well. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48642

Patch Set 1 : '' #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/common.gypi	View		3 chunks	+3 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

10 years, 6 months ago (2010-06-01 18:07:40 UTC) #2

I generally wrap .gyp/.gypi files to 80 characters, but for long conditional
expressions like this one, the possibility to introduce syntactical problems
when wrapping is about equal to the readability benefit, so I can go either way.
If it were me, I’d wrap it, but I won’t make you.

LGO.

http://codereview.chromium.org/2468002/diff/2001/3001
File build/common.gypi (right):

http://codereview.chromium.org/2468002/diff/2001/3001#newcode1176
build/common.gypi:1176: }],  # _type=="shared_library"
Fix this closing comment too.

Expand Messages | Collapse Messages