Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2468001: Fix generated code for String.charCodeAt. (Closed)

Created:
10 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix generated code for String.charCodeAt. Committed: http://code.google.com/p/v8/source/detail?r=4770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 6 months ago (2010-06-01 13:19:58 UTC) #1
Mads Ager (chromium)
LGTM
10 years, 6 months ago (2010-06-01 13:29:08 UTC) #2
Vyacheslav Egorov (Chromium)
10 years, 6 months ago (2010-06-01 13:39:28 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698