Issue 2467007: Bookmarks: Disable the sort command when there are no items to sort....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2467007: Bookmarks: Disable the sort command when there are no items to sort.... (Closed)

Created:
10 years, 6 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
feldstein

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bookmarks: Disable the sort command when there are no items to sort. BUG=39250 TEST=Select a folder with no items. The sort command should be disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48767

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
	M	chrome/browser/resources/bookmark_manager/main.html	View	1 2	3 chunks	+48 lines, -33 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

feldstein

Couple comments, otherwise lgtm http://codereview.chromium.org/2467007/diff/1/2 File chrome/browser/resources/bookmark_manager/main.html (right): http://codereview.chromium.org/2467007/diff/1/2#newcode1162 chrome/browser/resources/bookmark_manager/main.html:1162: console.log(list.items.length); remove logs before checking ...

10 years, 6 months ago (2010-06-02 21:13:58 UTC) #2

arv (Not doing code reviews)

10 years, 6 months ago (2010-06-02 21:22:24 UTC) #3

On 2010/06/02 21:13:58, feldstein wrote:
> Couple comments, otherwise lgtm
> 
> http://codereview.chromium.org/2467007/diff/1/2
> File chrome/browser/resources/bookmark_manager/main.html (right):
> 
> http://codereview.chromium.org/2467007/diff/1/2#newcode1162
> chrome/browser/resources/bookmark_manager/main.html:1162:
> console.log(list.items.length);
> remove logs before checking in
> 
> http://codereview.chromium.org/2467007/diff/1/2#newcode1171
> chrome/browser/resources/bookmark_manager/main.html:1171: e.canExecute =
> isRecentOrSearch;
> Should this be !isRecentOrSearch?

Yes, thanks for seeing this.

Expand Messages | Collapse Messages