Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2467006: Make StringCharCodeAt runtime function do what it name implies and not (Closed)

Created:
10 years, 6 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make StringCharCodeAt runtime function do what it name implies and not just indexed string access. The difference is that String.prototype.charCodeAt accepts any number as an index, whereas string[] only accepts array indices. Committed: http://code.google.com/p/v8/source/detail?r=4790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -70 lines) Patch
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +24 lines, -27 lines 0 comments Download
M test/mjsunit/string-charat.js View 2 chunks +47 lines, -42 lines 0 comments Download
M test/mjsunit/string-charcodeat.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Repeshko
10 years, 6 months ago (2010-06-02 14:59:50 UTC) #1
Vitaly Repeshko
I borrowed one of the tests from Vlad's http://codereview.chromium.org/2478003/show -- Vitaly
10 years, 6 months ago (2010-06-02 15:01:12 UTC) #2
Vladislav Kaznacheev
10 years, 6 months ago (2010-06-03 06:00:19 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698