Chromium Code Reviews

Issue 246077: Changed Object.keys to return strings for element indices. (Closed)

Created:
11 years, 2 months ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Changed Object.keys to return strings for element indices.

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+51 lines, -23 lines)
M src/factory.h View 1 chunk +2 lines, -0 lines 0 comments
M src/factory.cc View 1 chunk +5 lines, -0 lines 0 comments
M src/heap.h View 1 chunk +2 lines, -0 lines 0 comments
M src/heap.cc View 1 chunk +25 lines, -0 lines 0 comments
M src/runtime.cc View 2 chunks +15 lines, -23 lines 0 comments
M test/mjsunit/third_party/object-keys.js View 1 chunk +2 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
11 years, 2 months ago (2009-10-02 13:13:03 UTC) #1
Mads Ager (chromium)
11 years, 2 months ago (2009-10-02 13:18:31 UTC) #2
LGTM

Powered by Google App Engine