Issue 246076: Change clamping 0..255 instruction sequence for pixel array code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246076: Change clamping 0..255 instruction sequence for pixel array code (Closed)

Created:
11 years, 2 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Tobias Kaes

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change clamping 0..255 instruction sequence for pixel array code. The subb instruction added to the IA-32 assembler is not used as dec_b ended up being used instead. There is a mesurable difference. Committed: http://code.google.com/p/v8/source/detail?r=3033

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -12 lines)			Patch
M	src/ia32/assembler-ia32.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1	3 chunks	+2 lines, -7 lines	2 comments	Download
M	src/x64/assembler-x64.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tobias Kaes

http://codereview.chromium.org/246076/diff/8005/8008 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/246076/diff/8005/8008#newcode426 Line 426: Label done, is_negative; is_negative isn't used anymore, is ...

11 years, 2 months ago (2009-10-08 07:42:43 UTC) #3

Søren Thygesen Gjesse

11 years, 2 months ago (2009-10-08 07:46:13 UTC) #4

http://codereview.chromium.org/246076/diff/8005/8008
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/246076/diff/8005/8008#newcode426
Line 426: Label done, is_negative;
On 2009/10/08 07:42:43, Tobias Kaes wrote:
> is_negative isn't used anymore, is it?

Absolutely right, I will get rid of it.

Expand Messages | Collapse Messages