Issue 246064: Revert change r3004, issue http://codereview.chromium.org/244022, because Lin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246064: Revert change r3004, issue http://codereview.chromium.org/244022, because Lin... (Closed)

Created:
11 years, 2 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Revert change r3004, issue http://codereview.chromium.org/244022, because Linux 64-bit Chrome crashes with more than 10 tabs. Linux may not like 10 processes, each reserving 2 GB of virtual address space. Committed: http://code.google.com/p/v8/source/detail?r=3006

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -281 lines)			Patch
M	src/heap.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.cc	View	4 chunks	+0 lines, -13 lines	0 comments	Download
M	src/spaces.h	View	3 chunks	+2 lines, -72 lines	0 comments	Download
M	src/spaces.cc	View	3 chunks	+3 lines, -133 lines	0 comments	Download
M	test/cctest/test-alloc.cc	View	1 chunk	+0 lines, -62 lines	0 comments	Download

Total messages: 2 (0 generated)

William Hesse

TBR=ager@chromium.org, reverting change r3004, because Chrome64 on Linux crashes.

11 years, 2 months ago (2009-10-01 15:15:56 UTC) #1

Mads Ager (chromium)

11 years, 2 months ago (2009-10-02 06:05:12 UTC) #2

LGTM.

We had a total limit of 1GB for the entire old generation before, so we probably
don't need more than a fraction of that for code in any case.