Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 246042: Added command line argument --enable-webgl to facilitate turning on... (Closed)

Created:
11 years, 2 months ago by Ken Russell (Google)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org
Visibility:
Public.

Description

Added command line argument --enable-webgl to facilitate turning on ENABLE_3D_CANVAS in development builds. Currently this argument also requires disabling the sandbox. BUG=http://crbug.com/21852 TEST=none (runs preexisting WebGL layout tests; more coming) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27637

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webkit/api/public/WebSettings.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/api/src/WebSettingsImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/api/src/WebSettingsImpl.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
11 years, 2 months ago (2009-09-30 02:14:04 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/246042/diff/1/6 File webkit/glue/webpreferences.cc (right): http://codereview.chromium.org/246042/diff/1/6#newcode85 Line 85: settings->setExperimentalWebGLEnabled(experimental_webgl_enabled); nit: it would be nice to ...
11 years, 2 months ago (2009-09-30 04:20:00 UTC) #2
Ken Russell (switch to Gerrit)
11 years, 2 months ago (2009-09-30 18:35:00 UTC) #3
http://codereview.chromium.org/246042/diff/1/6
File webkit/glue/webpreferences.cc (right):

http://codereview.chromium.org/246042/diff/1/6#newcode85
Line 85: settings->setExperimentalWebGLEnabled(experimental_webgl_enabled);
On 2009/09/30 04:20:00, darin wrote:
> nit: it would be nice to group all of the function calls made on settings
> together.

Done.

Powered by Google App Engine
This is Rietveld 408576698